Nathan Vegdahl nathanvegdahl
  • Amsterdam, Netherlands
  • https://cessen.com
  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Nathan Vegdahl commented on pull request blender/blender#110912 2023-08-10 14:07:22 +02:00
USD: Skeleton and blend shape import

This is probably better as future work, but for sampled animation data it should be possible to just convert the animation data to be equivalent for the skeleton we actually end up with. On the other hand, it might just not be worth it, and maybe there are round-tripping considerations I'm not aware of here.

Nathan Vegdahl commented on pull request blender/blender#110912 2023-08-10 14:07:21 +02:00
USD: Skeleton and blend shape import

I might be misunderstanding the comment, but I think by deform groups you mean vertex groups? That's the Blender terminology.

Nathan Vegdahl commented on pull request blender/blender#110912 2023-08-10 14:07:21 +02:00
USD: Skeleton and blend shape import

I think this can be const.

Nathan Vegdahl commented on pull request blender/blender#110912 2023-08-10 14:07:20 +02:00
USD: Skeleton and blend shape import

Typo: sekeleton > skeleton

Nathan Vegdahl approved blender/blender#110586 2023-08-10 12:23:16 +02:00
Animation: Right align slider unit text

Looks good to me. Definitely agree this is a better approach to aligning the text.

Nathan Vegdahl commented on pull request blender/blender#110544 2023-08-10 11:52:45 +02:00
Animation: Blend Offset Slider

Oh... except it looks like there's conflicts now. Just fix that up and I'll do a quick re-review. But it's otherwise ready to land.

Nathan Vegdahl commented on pull request blender/blender#110567 2023-08-10 11:49:09 +02:00
Animation: Match Slope slider

The consensus in the module meeting was to rename this to "Match Slope". Other than that, this looks ready to land to me.

Nathan Vegdahl commented on pull request blender/blender#110566 2023-08-10 11:47:18 +02:00
Animation: Blend To Ease Slider

The consensus in the module meeting was that this useful. Just the one nit, and then it's ready to land.

Nathan Vegdahl approved blender/blender#110544 2023-08-10 11:45:50 +02:00
Animation: Blend Offset Slider

Consensus in the meeting was to approve! :-)

Nathan Vegdahl approved blender/blender#110764 2023-08-10 11:37:23 +02:00
Animation: Common curve drawing for FCurves

Looks good to me!

Nathan Vegdahl commented on pull request blender/blender#110764 2023-08-10 11:35:26 +02:00
Animation: Common curve drawing for FCurves

Huh, that's odd. Wonder why it behaved differently on my system. Oh well. :-)

Nathan Vegdahl commented on pull request blender/blender#110941 2023-08-09 13:35:21 +02:00
AgX-Step4: Add and Rename Colorspaces

I feel more confortable doing so after all things are figured out.

Yeah, that's a good point. Sounds good.

Nathan Vegdahl commented on pull request blender/blender#110941 2023-08-09 13:31:20 +02:00
AgX-Step4: Add and Rename Colorspaces

I have experimented with Rec.2100 but I don't have a finished version of AgX for it. Still experimenting.

I don't think their inclusion should be blocked on AgX support. The point is to…

Nathan Vegdahl commented on pull request blender/blender#110941 2023-08-09 13:03:46 +02:00
AgX-Step4: Add and Rename Colorspaces

Not sure if it should be in this PR or not, but at some point I think it would be good to also add Rec.2100 (both HLG and PQ) as display spaces as well.

Nathan Vegdahl commented on pull request blender/blender#110941 2023-08-09 12:59:13 +02:00
AgX-Step4: Add and Rename Colorspaces

Is E-Gamut actually used much outside of FilmLight's own tools and configurations? I could very well just be out of the loop on this, but my initial reactions was that it feels kind of specific and maybe not appropriate in a general configuration.

Nathan Vegdahl commented on pull request blender/blender#110913 2023-08-09 12:45:29 +02:00
AgX-Step3: Refactor OCIO config to be CIE XYZ I-E based

I could see that. But to expand on my perspective:

To me it's more that CIE XYZ doesn't have a white point in the traditional sense. In RGB color spaces, for example, the white point plays…

Nathan Vegdahl commented on pull request blender/blender#110941 2023-08-09 12:24:24 +02:00
AgX-Step4: Add and Rename Colorspaces

Illuminant E version of the above spaces for Spectral Cycles to potentially utilize

Adapting colors to white point E will definitely be useful for spectral Cycles, yes. It's needed to…

Nathan Vegdahl commented on pull request blender/blender#110913 2023-08-09 10:42:43 +02:00
AgX-Step3: Refactor OCIO config to be CIE XYZ I-E based

Sorry I'm a bit late to this. Didn't realize it would get merged so quickly.

A tiny nit: rather than Linear CIE-XYZ I-E or Linear CIE-XYZ E it can just be Linear CIE XYZ. X=Y=Z is…

Nathan Vegdahl commented on pull request blender/blender#110758 2023-08-08 18:57:05 +02:00
Bendy Bones: implement a new curve-aware vertex to segment mapping mode.

I mean, what would even be the logic, and how would it look?

My initial thought would be something like the lines (well, planes really) curving to become parallel before they intersect. …

Nathan Vegdahl commented on pull request blender/blender#110758 2023-08-08 13:42:45 +02:00
Bendy Bones: implement a new curve-aware vertex to segment mapping mode.

How do you imagine that kind of thing applying here at all?

I wasn't suggesting using the smooth absolute value function—that obviously doesn't apply. It was an example of taking a mapping…