- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21 -
-
Since this function is duplicated in three places, maybe it makes sense to just define it once in one place to be reused everywhere? Not sure if there's a semantic difference between the three copies that I'm missing.
Instead of adding an alias, it might make sense to change the existing name to a new name that encompasses both. Maybe SCE_SNAP_ABS_INCREMENT?
Is rna_enum_snap_action_element_items used anywhere? I couldn't find it. Then again, RNA stuff still seems a little magical to me sometimes, so I easily could have just missed it.
Gah! Also, I forgot to report back after the animation & rigging module meeting. The two main things discussed were:
- We're a bit concerned that this makes the driver editor UI even more…
@guishe You have both this and #109980 open for fixing #109081. Do you think one or the other is better? And can you elaborate on what the pros/cons of the two different fixes are?
I have an itchy finger just waiting to hit "approve". 😉 Just waiting on these function renames.
Code looks good to me.
As in #110567 and #110566, I'm not sure what the use case is for this. The closest I can think of is flattening out a section of animation (which definitely comes up, in…
Might make sense to move the declaration of y_delta inside the for loop below, closer to where it's used.
The code looks good to me. But I have a couple of thoughts:
- The name "Blend to Infinity" was not at all suggestive to me of what this feature does. How does "Blend to Slope" sound?
- I…
Nothing to do with this PR, but just a side-note that these fcurve_segment_*_get() functions are (IMO) poorly named. I would expect them to get the first and last keys within the selected segment, but in fact they attempt to get the keys before and after the segment, which are not themselves part of the segment (falling back to the actual start and end key of the segment only if the before/after don't exist).
If a "fallback" to use a default value considered an error then it feels that the default value is just there to help hiding the error, which is not really good. If use of a default value is…
This is only true if we will never change the working space to BT.2020 or ACEScg in the future.
Or if we explicitly provide a linear sRGB/Rec.709 output display transform, which is the…
But we will go with piece-wise for this project, as confirmed by Sergey. Whether sRGB should be changed to 2.2 will be a discussion separated from this current one.
Yeah, that's a good…
Most of what has been discussed here so far makes sense to me, aside from some subtleties that we may want to consider at some point. I'll post about those later when I have time to collect my…
and there might be others reading the code that never heard of it either.
Totally fair! And indeed, you not knowing what it meant is probably a good indication to avoid the math jargon…
Oh, that's a good point. But rather than changing what they return, I wonder if just changing the names to get_extrapolation_point_left/right would make sense. Then they're consistent with…
I was puzzling if this or max(resolution_x, resolution_y) makes more sense. And I've come to the tentative conclusion that summing is probably not only better than max but actually even better than the square-root (Euclidean) distance calculation.