- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21 -
-
In particular, a member function is not symmetric with respect to the types of the two operands, the left-hand-side (lhs) must be of the exact type of the class on which it is being called,…
Looks good to me. Also learned something about how colors are stored more compactly in the rendering code, ha ha. :-)
Interesting. I'm rather indifferent, or maybe even slightly prefer a free function as well for stylistic reasons.
But I am curious, because I don't follow the rationale given in the linked…
Mostly looks good to me. Just some nits and questions.
Just double-checking: this is just an optimization, right? If so, looks good. If not, a comment would be good.
Nit: maybe "further below", or something else to help indicate that it's quite a ways away. My initial gut reaction was that it would be just below along with the flag methods, and it took me a bit to reorient and find it a page or so down.
When does this happen? Should this have an assert?
Is this function useful/necessary? It seems redundant with action_bindinghandle_to_keylist() since the parameters are identical except for taking a Binding handle rather than a Binding. But that one difference is trivial to handle at the call sites by just passing binding.handle as seen in the implementation here.
A doc comment would be good (just a short-and-sweet one is fine). From just the name/signature and without the context of the larger PR I don't think its purpose/behavior would be clear to me, at least.