Christoph Lendenfeld ChrisLend
3 Followers · 0 Following
Overview Repositories
4
 Projects Public Activity Starred Repositories
Christoph Lendenfeld closed issue blender/blender#103855 2023-04-13 15:34:59 +02:00
Animation Editors Paper Cuts
Christoph Lendenfeld commented on issue blender/blender#103855 2023-04-13 15:34:57 +02:00
Animation Editors Paper Cuts

thanks for all the ideas, I consider this task finished now. Not all things I looked at could be implemented easily, that doesn't mean they are off the table, just that they are more work than…

Christoph Lendenfeld created pull request blender/blender#106904 2023-04-13 15:17:47 +02:00
Fix #106771: Selection offset in timeline when NLA track is offset
Christoph Lendenfeld pushed to fix_keyframe_selection at ChrisLend/blender 2023-04-13 15:14:09 +02:00
6048f4240b fix
aa6e95281f Add support for OpenPGL 0.5.0
c26083b6be Fix warning in the STL code
e5d50b1787 Fix Cycles unknown passes logged when build with Cycles debug
34739f6a6d Fix #106672: MacOS/OpenGL doesn't draw anything Eevee related.
Compare 5 commits »
Christoph Lendenfeld created branch fix_keyframe_selection in ChrisLend/blender 2023-04-13 15:14:09 +02:00
Christoph Lendenfeld suggested changes for blender/blender#106520 2023-04-13 12:59:31 +02:00
Animation: time offset slider

needs a memory allocation. Currently it doesn't compile for me

Christoph Lendenfeld commented on pull request blender/blender#106520 2023-04-13 12:59:31 +02:00
Animation: time offset slider

this doesn't compile for me. C doesn't allow variable length arrays.

Christoph Lendenfeld commented on pull request blender/blender#106520 2023-04-13 12:59:30 +02:00
Animation: time offset slider

forgot the . at the end of the comment

Christoph Lendenfeld commented on pull request blender/blender#106518 2023-04-13 12:33:25 +02:00
Animation: blend offset slider

if you use ED_slider_is_bidirectional_set you can just say factor > 0 and remove the boolean

Christoph Lendenfeld suggested changes for blender/blender#106518 2023-04-13 12:33:25 +02:00
Animation: blend offset slider

minor comments :)

Christoph Lendenfeld commented on pull request blender/blender#106518 2023-04-13 12:33:24 +02:00
Animation: blend offset slider

watch out for typos poritive -> positive

Christoph Lendenfeld commented on pull request blender/blender#106518 2023-04-13 12:33:24 +02:00
Animation: blend offset slider

this can be simplified to fcu->bezt[segment->start_index]

Christoph Lendenfeld suggested changes for blender/blender#106519 2023-04-13 12:15:19 +02:00
Animation: blend to ease slider

really nice! Good job on making the s_curve function. could potentially be used in ease_fcurve_segment as well

Christoph Lendenfeld commented on pull request blender/blender#106519 2023-04-13 12:15:18 +02:00
Animation: blend to ease slider

you can also set the slider itself to go from -1/1 using ED_slider_is_bidirectional_set

Christoph Lendenfeld commented on pull request blender/blender#106519 2023-04-13 12:15:18 +02:00
Animation: blend to ease slider

this could be renamed to y or curve_y

Christoph Lendenfeld commented on pull request blender/blender#106517 2023-04-13 11:57:08 +02:00
Animation: blend to infinity slider

I've been looking at the code properly now. I noticed you have a potential "index out of bounds" issue.

fcurve_segment_start_get already gets you the key with index 1 left of the selection.…

Christoph Lendenfeld created pull request blender/blender#106890 2023-04-13 10:56:13 +02:00
Fix: Normalization with baked curves and preview range
c244cdd5a9 fix
Christoph Lendenfeld created pull request blender/blender#106888 2023-04-13 10:22:01 +02:00
FIx: Respect preview range when auto normalizing in Graph Editor