Fix #109040: Don't calculate homogenous offset if viewspace offset is zero #109657

Jorijn de Graaf · 2023-07-03T17:44:13+02:00

Jorijn de Graaf commented

2023-07-03 17:44:13 +02:00

Users were reporting offset issues when the retopology overlay was disabled.
The reason those issues were happening is because of vs_offset = min(vs_offset, vs_z * -0.5);.
That line is necessary for proper functioning of the retopology overlay, but causes issues at lower offset values (such as zero, when the retopology overlay is disabled).

Also fixes #109640

Users were reporting offset issues when the retopology overlay was disabled. The reason those issues were happening is because of `vs_offset = min(vs_offset, vs_z * -0.5);`. That line is necessary for proper functioning of the retopology overlay, but causes issues at lower offset values (such as zero, when the retopology overlay is disabled). Also fixes #109640

Jorijn de Graaf added 1 commit 2023-07-03 17:44:24 +02:00

9370e77031 Don't calculate homogenous offset if viewspace offset is zero

Users were reporting offset issues when the retopology overlay was disabled.
The reason those issues were happening is because of `vs_offset = min(vs_offset, vs_z * -0.5);`.
That line is necessary for proper functioning of the retopology overlay, but causes issues at lower offset values (such as zero, which the retopology overlay is disabled).
This is kind of a band-aid solution, but it's a solution nonetheless.

Jorijn de Graaf requested review from Jeroen Bakker 2023-07-03 17:55:56 +02:00

Jorijn de Graaf requested review from Clément Foucault 2023-07-03 17:55:56 +02:00

Jorijn de Graaf commented

2023-07-03 17:59:42 +02:00

This is kind of a band-aid solution, but it's a solution nonetheless.
And I suppose it's cheaper to render? Unless the extra if statement weighs more than the math that's now skipped.
In the future we may want to come up with better offset math, but for now this at least makes it so the retopology math doesn't mess with offset when retopology is disabled.

This is kind of a band-aid solution, but it's a solution nonetheless. And I suppose it's cheaper to render? Unless the extra if statement weighs more than the math that's now skipped. In the future we may want to come up with better offset math, but for now this at least makes it so the retopology math doesn't mess with offset when retopology is disabled.

Jorijn de Graaf changed title from ~~Fix #109040 and #109640: Don't calculate homogenous offset if viewspace offset is zero~~ to Fix #109040: Don't calculate homogenous offset if viewspace offset is zero

2023-07-03 18:05:59 +02:00

Jorijn de Graaf referenced this pull request

2023-07-05 13:34:48 +02:00

Regression: Selecting a face selects the one behind it when zoomed in #109717

Jeroen Bakker added the

Module

EEVEE & Viewport

label 2023-07-10 08:00:25 +02:00

Jeroen Bakker added this to the 3.6 LTS milestone 2023-07-10 08:00:30 +02:00

Jeroen Bakker added this to the EEVEE & Viewport project 2023-07-10 08:00:35 +02:00

Jeroen Bakker approved these changes 2023-07-10 08:00:48 +02:00

Clément Foucault approved these changes 2023-07-10 12:00:36 +02:00