Cycles HIP device #91571

Open
opened 2021-09-21 16:02:12 +02:00 by Brecht Van Lommel · 134 comments

Tasks to keep track of HIP device development tasks.

  • Windows support and stability
    • Upgrade HIP SDK to 22.10
    • RDNA2
    • RDNA1
    • Vega
  • Linux support and stability
    • Crash in hipGetDeviceProperties
    • RDNA3 (D16507)
    • RDNA2
    • RDNA1 (#97591)
    • Vega
  • Hardware ray-tracing
  • Wiki build documentation for building with hipcc on Linux and Windows
  • Clip mode in Image Texture node not supported (#92975)
  • Image texture size is limited, could detect this and resize or show user better error (#94057, #93109)
  • Deduplicate CUDA and HIP host code
  • Graphics interop (Wait until overall HIP stability improves before risking this)
  • Compute capability checking (if needed)
  • Integrator state size estimation depending on the GPU

Completed for 3.0 release:

  • Buildbot setup of hipcc
    • Install on CentOS workers
    • Install on Windows workers
    • Enable Windows binaries on the buildbot
  • Determine range of supported cards on Linux and Windows for 3.0
  • Detect supported cards in the code (D12958)
  • Bug: instancing rendering artifact in bmw27 scene
  • Supported GPU hardware list for documentation
  • #92972 (Cycles HIP graphics interop issue on AMD 5500 XT and Windows)
  • Windows driver available
  • #92984 (Cycles HIP crash with smoke volume)
  • #93109 (Cycles HIP device missing driver version check)
Tasks to keep track of HIP device development tasks. - [x] Windows support and stability - [x] Upgrade HIP SDK to 22.10 - [x] RDNA2 - [x] RDNA1 - [x] Vega - [x] Linux support and stability - [x] Crash in `hipGetDeviceProperties` - [x] RDNA3 ([D16507](https://archive.blender.org/developer/D16507)) - [x] RDNA2 - [x] RDNA1 (#97591) - [x] Vega - [x] Hardware ray-tracing - [x] Wiki build documentation for building with hipcc on Linux and Windows - [ ] Clip mode in Image Texture node not supported (#92975) - [ ] Image texture size is limited, could detect this and resize or show user better error (#94057, #93109) - [ ] Deduplicate CUDA and HIP host code - [ ] ~~Graphics interop~~ (Wait until overall HIP stability improves before risking this) - [x] Compute capability checking (if needed) - [x] Integrator state size estimation depending on the GPU Completed for 3.0 release: - [x] Buildbot setup of hipcc - [x] Install on CentOS workers - [x] Install on Windows workers - [x] Enable Windows binaries on the buildbot - [x] Determine range of supported cards on Linux and Windows for 3.0 - [x] Detect supported cards in the code ([D12958](https://archive.blender.org/developer/D12958)) - [x] Bug: instancing rendering artifact in bmw27 scene - [x] Supported GPU hardware list for documentation - [x] #92972 (Cycles HIP graphics interop issue on AMD 5500 XT and Windows) - [x] Windows driver available - [x] #92984 (Cycles HIP crash with smoke volume) - [x] #93109 (Cycles HIP device missing driver version check)
Author
Owner

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Author
Owner

Added subscriber: @brecht

Added subscriber: @brecht
Contributor

Added subscriber: @Raimund58

Added subscriber: @Raimund58

Added subscriber: @SteffenD

Added subscriber: @SteffenD

Added subscriber: @BrianSavery

Added subscriber: @BrianSavery

Added subscriber: @GeorgiaPacific

Added subscriber: @GeorgiaPacific
Member

Added subscriber: @Alaska

Added subscriber: @Alaska

Added subscriber: @Stat_Headcrabed

Added subscriber: @Stat_Headcrabed

So AMD GPU cannot use blender on windows even after HIP support is implemented?

So AMD GPU cannot use blender on windows even after HIP support is implemented?
Contributor

@Stat_Headcrabed Even with HIP implemented it would currently not work because the GPU driver to support it is not released yet.

@Stat_Headcrabed Even with HIP implemented it would currently not work because the GPU driver to support it is not released yet.
Member

In #91571#1223528, @Stat_Headcrabed wrote:
So AMD GPU cannot use blender on windows even after HIP support is implemented?

At the moment it seems like the HIP implementation works on Linux with the right setup. There appear to be plans to add Windows support via the release of tools and a new GPU driver in the coming months. The current time line suggest that Windows support should be avaliable before the relase of Blender 3.0, but it is not garunteed that the HIP implementation will be added to/or enabled in Blender with the 3.0 release.

Notes about it can be found in the Render Meeting Notes : https://devtalk.blender.org/c/blender/meetings-archive/18

Plan to post a public patch soon in time for the 3.0 release, however drivers and compiler will not be available yet at that time. Since this can be disabled by default with a build option it’s fine to continue development like this in cycles-x/master to make things easier.

bsavery: this part pretty much explains it. HIP support will have a PR soon to the cycles-x, but the driver and compiler will not be available publicly yet (these should be available before Blender 3.0 releases.)
Source: https://devtalk.blender.org/t/2021-08-31-blender-rendering-meeting/20206/3

AMD HIP support will be submitted to code review soon, review will be prioritized by William and Brecht to make the deadline. As mentioned before, the required graphics drivers will not be available at the time this is expected to be merged, so it will not be immediately available for user testing.
Source: https://devtalk.blender.org/t/2021-09-14-blender-rendering-meeting/20469

> In #91571#1223528, @Stat_Headcrabed wrote: > So AMD GPU cannot use blender on windows even after HIP support is implemented? At the moment it seems like the HIP implementation works on Linux with the right setup. There appear to be plans to add Windows support via the release of tools and a new GPU driver in the coming months. The current time line suggest that Windows support should be avaliable before the relase of Blender 3.0, but it is not garunteed that the HIP implementation will be added to/or enabled in Blender with the 3.0 release. Notes about it can be found in the `Render Meeting Notes` : https://devtalk.blender.org/c/blender/meetings-archive/18 >>Plan to post a public patch soon in time for the 3.0 release, however drivers and compiler will not be available yet at that time. Since this can be disabled by default with a build option it’s fine to continue development like this in cycles-x/master to make things easier. >bsavery: this part pretty much explains it. HIP support will have a PR soon to the cycles-x, but the driver and compiler will not be available publicly yet (these should be available before Blender 3.0 releases.) >Source: https://devtalk.blender.org/t/2021-08-31-blender-rendering-meeting/20206/3 >AMD HIP support will be submitted to code review soon, review will be prioritized by William and Brecht to make the deadline. As mentioned before, the required graphics drivers will not be available at the time this is expected to be merged, so it will not be immediately available for user testing. >Source: https://devtalk.blender.org/t/2021-09-14-blender-rendering-meeting/20469

This issue was referenced by blender/cycles@fedbb9c898

This issue was referenced by blender/cycles@fedbb9c8987a67d0ca1a28ad1e6807436dea0568

This issue was referenced by 044a77352f

This issue was referenced by 044a77352f8a8a0e1f60190369d69ef26587b65f

Added subscriber: @AndyCuccaro

Added subscriber: @AndyCuccaro

Added subscriber: @julian8bruns

Added subscriber: @julian8bruns

Added subscriber: @2046411367

Added subscriber: @2046411367

Added subscriber: @easythrees

Added subscriber: @easythrees
Author
Owner

@BrianSavery , I'm trying to set this up on the buildbot but running into some issues. I did various improvements and fixes in 55b8fc7, but still running into problems.

  • What is CYCLES_HIP_BINARIES_ARCH support to be set to?
  • I get errors running hipcc, not sure if they would all be fixed by providing a proper architecture:
-- Found HIP /usr/bin/hipcc (4.3.21300)
...
[1/4] Generating kernel_unknown.fatbin
FAILED: intern/cycles/kernel/kernel_unknown.fatbin 
cd /home/brecht/dev/build_linux/intern/cycles/kernel && /usr/bin/hipcc -arch=unknown --fatbin /home/brecht/dev/blender/intern/cycles/kernel/device/hip/kernel.cpp -D CCL_NAMESPACE_BEGIN= -D CCL_NAMESPACE_END= -D HIPCC -m 64 -I /home/brecht/dev/blender/intern/cycles/kernel/.. -I /home/brecht/dev/blender/intern/cycles/kernel/device/hip --use_fast_math -o /home/brecht/dev/build_linux/intern/cycles/kernel/kernel_unknown.fatbin -D WITH_NANOVDB -I /home/brecht/dev/lib/linux_centos7_x86_64/nanovdb/include
clang-13: error: unsupported option '--fatbin'
clang-13: error: unsupported option '--use_fast_math'
clang-13: error: unknown argument: '-m'
clang-13: error: no such file or directory: '64'
@BrianSavery , I'm trying to set this up on the buildbot but running into some issues. I did various improvements and fixes in 55b8fc7, but still running into problems. * What is `CYCLES_HIP_BINARIES_ARCH` support to be set to? * I get errors running hipcc, not sure if they would all be fixed by providing a proper architecture: ``` -- Found HIP /usr/bin/hipcc (4.3.21300) ... [1/4] Generating kernel_unknown.fatbin FAILED: intern/cycles/kernel/kernel_unknown.fatbin cd /home/brecht/dev/build_linux/intern/cycles/kernel && /usr/bin/hipcc -arch=unknown --fatbin /home/brecht/dev/blender/intern/cycles/kernel/device/hip/kernel.cpp -D CCL_NAMESPACE_BEGIN= -D CCL_NAMESPACE_END= -D HIPCC -m 64 -I /home/brecht/dev/blender/intern/cycles/kernel/.. -I /home/brecht/dev/blender/intern/cycles/kernel/device/hip --use_fast_math -o /home/brecht/dev/build_linux/intern/cycles/kernel/kernel_unknown.fatbin -D WITH_NANOVDB -I /home/brecht/dev/lib/linux_centos7_x86_64/nanovdb/include clang-13: error: unsupported option '--fatbin' clang-13: error: unsupported option '--use_fast_math' clang-13: error: unknown argument: '-m' clang-13: error: no such file or directory: '64' ```

Added subscriber: @fire

Added subscriber: @fire

Added subscriber: @pauanyu_blender

Added subscriber: @pauanyu_blender
Member

Added subscriber: @Sayak-Biswas

Added subscriber: @Sayak-Biswas

Added subscriber: @2905710881

Added subscriber: @2905710881

amd yes

amd yes

Added subscriber: @LahceneB

Added subscriber: @LahceneB
Contributor

Added subscriber: @IyadAhmed

Added subscriber: @IyadAhmed

Added subscriber: @AndreaMonzini

Added subscriber: @AndreaMonzini

As GNU/Linux user i think it would be important to help ( and ideally support ) the ROCm/HIP installation on other distros like for example Arch, GUIX Sytem, NixOS.
Or with Cycles HIP we will have less freedom on the OS we can use compared to the Cycles on OpenCL.

Anyway thank you for your work !

As GNU/Linux user i think it would be important to help ( and ideally support ) the ROCm/HIP installation on other distros like for example Arch, GUIX Sytem, NixOS. Or with Cycles HIP we will have less freedom on the OS we can use compared to the Cycles on OpenCL. Anyway thank you for your work !

Added subscriber: @FreeCX

Added subscriber: @FreeCX
pikhosh commented 2021-10-18 10:50:07 +02:00 (Migrated from localhost:3001)

Added subscriber: @pikhosh

Added subscriber: @pikhosh

Added subscriber: @Chou-Vieux

Added subscriber: @Chou-Vieux

Added subscriber: @Diogo_Valadares

Added subscriber: @Diogo_Valadares

Added subscriber: @s12a

Added subscriber: @s12a

Added subscriber: @Low_Polygon42

Added subscriber: @Low_Polygon42

Thank you for all your hard work. This will add more options as to the choices creators have when it comes to gpu's. Again, thank you.

Thank you for all your hard work. This will add more options as to the choices creators have when it comes to gpu's. Again, thank you.
Member

Added subscriber: @leesonw

Added subscriber: @leesonw

Added subscriber: @FogLizard

Added subscriber: @FogLizard

I have installed full rocm on Arch Linux and enabled HIP in CMakeLists.txt by overriding the options in the blender-git PKGBUILD, I do have HIP option under system preferences and my GPU and CPU shows up there.

However if I try to render with Cycles and GPU Compute, render fails with the following error:

Invalid value in hipDeviceGetAttribute(&pitch_alignment, hipDeviceAttributeTexturePitchAlignment, hipDevice)) (intern/cycles/device/hip/device_impl.cpp:116)

I have a Vega 64 and I've checked with rocminfo that it's arch is gfx900, which is missing in CMakeLists.txt:

set(CYCLES_HIP_BINARIES_ARCH gfx1010 gfx1011 gfx1012 gfx1030 gfx1031 gfx1032 gfx1034 CACHE STRING "AMD HIP architectures to build binaries for")

I have tried overriding this option in PKGBUILD file and recompiling, but apparently it didn't work.

cmake -G Ninja -S "$srcdir/blender" -B build
- C "${srcdir}/blender/build_files/cmake/config/blender_release.cmake"
- DCMAKE_INSTALL_PREFIX=/usr
- DCMAKE_BUILD_TYPE=Release
- DWITH_INSTALL_PORTABLE=OFF
- DWITH_SYSTEM_GLEW=OFF
- DWITH_PYTHON_INSTALL=OFF
- DWITH_CYCLES_DEVICE_HIP=ON
- DWITH_CYCLES_HIP_BINARIES=ON
- DCYCLES_HIP_BINARIES_ARCH=gfx900
- DXR_OPENXR_SDK_ROOT_DIR=/usr
- DPYTHON_VERSION="${_pyver}" \

      "${_CMAKE_FLAGS[@]}"
ninja -C "$srcdir/build" ${MAKEFLAGS:--j1}

Please add Vega 64 arch gfx900 support, as it supports HIP, or let me know how to do it manually.

I have installed full rocm on Arch Linux and enabled HIP in CMakeLists.txt by overriding the options in the blender-git PKGBUILD, I do have HIP option under system preferences and my GPU and CPU shows up there. However if I try to render with Cycles and GPU Compute, render fails with the following error: Invalid value in hipDeviceGetAttribute(&pitch_alignment, hipDeviceAttributeTexturePitchAlignment, hipDevice)) (intern/cycles/device/hip/device_impl.cpp:116) I have a Vega 64 and I've checked with rocminfo that it's arch is gfx900, which is missing in CMakeLists.txt: set(CYCLES_HIP_BINARIES_ARCH gfx1010 gfx1011 gfx1012 gfx1030 gfx1031 gfx1032 gfx1034 CACHE STRING "AMD HIP architectures to build binaries for") I have tried overriding this option in PKGBUILD file and recompiling, but apparently it didn't work. cmake -G Ninja -S "$srcdir/blender" -B build \ - C "${srcdir}/blender/build_files/cmake/config/blender_release.cmake" \ - DCMAKE_INSTALL_PREFIX=/usr \ - DCMAKE_BUILD_TYPE=Release \ - DWITH_INSTALL_PORTABLE=OFF \ - DWITH_SYSTEM_GLEW=OFF \ - DWITH_PYTHON_INSTALL=OFF \ - DWITH_CYCLES_DEVICE_HIP=ON \ - DWITH_CYCLES_HIP_BINARIES=ON \ - DCYCLES_HIP_BINARIES_ARCH=gfx900 \ - DXR_OPENXR_SDK_ROOT_DIR=/usr \ - DPYTHON_VERSION="${_pyver}" \ ``` "${_CMAKE_FLAGS[@]}" ninja -C "$srcdir/build" ${MAKEFLAGS:--j1} ``` Please add Vega 64 arch gfx900 support, as it supports HIP, or let me know how to do it manually.
Member

In #91571#1240208, @FogLizard wrote:
Please add Vega 64 arch gfx900 support, as it supports HIP, or let me know how to do it manually.

Official instructions on how to setup HIP in Cycles will be avalibale in the future. Once the instructions are released, it should be better.

As a side note, I'm not familiar with with the build method you're using, but I would suggest using the official build instructions listed on the Blender website: https://wiki.blender.org/wiki/Building_Blender
And once you've got Blender compiled and working, navigate to ~/blender-git/build-linux/ and modify the file CMakeCache.txt with an application like cmake-gui to enable HIP and add your desired architectures then rebuild Blender again. I would personally recommend adding more architectures than just your GPU just in case you've got the wrong number. Here is a list of GPU architectures that Brecht said compiles, but he hasn't tested all of them yet:

gfx801;gfx803;gfx810;gfx900;gfx902;gfx904;gfx906;gfx908;gfx909;gfx1010;gfx1011;gfx1012;gfx1030;gfx1031;gfx1032

You might also need to change some code in intern/cycles/device/hip/util.h for everything to work properly. You can see an example in this commit on what sort of changes should be done: 2f89ddc043

It might actually be easier to test with the cycles-hip-binaries branch of Blender. This can be done by using git checkout cycles-hip-binaries in the Blender source code directory to checkout that branch then to compile a clean build of Blender from that.


On a side note. There is a version of Blender avaliable for download with the HIP binaries pre-compiled. It should recognize a wide range of GPUs, but I have no idea if it's functional, you will probably experience some bugs, and this version of Blender will quickly become outdated so we do NOT accept bug reports for it: https://builder-uatest.blender.org/download/experimental/cycles-hip-binaries/


It should also be noted that at the current point in time Vega 64 isn't "officially" supported. It may work, but with the currently avaliable official Blender code Vega 64 isn't on the list of supported GPUs. It's also possible you may experience bugs due to the HIP implementation still being under development.

> In #91571#1240208, @FogLizard wrote: > Please add Vega 64 arch gfx900 support, as it supports HIP, or let me know how to do it manually. Official instructions on how to setup HIP in Cycles will be avalibale in the future. Once the instructions are released, it should be better. As a side note, I'm not familiar with with the build method you're using, but I would suggest using the official build instructions listed on the Blender website: https://wiki.blender.org/wiki/Building_Blender And once you've got Blender compiled and working, navigate to `~/blender-git/build-linux/` and modify the file `CMakeCache.txt` with an application like `cmake-gui` to enable HIP and add your desired architectures then rebuild Blender again. I would personally recommend adding more architectures than just your GPU just in case you've got the wrong number. Here is a list of GPU architectures that Brecht said compiles, but he hasn't tested all of them yet: > gfx801;gfx803;gfx810;gfx900;gfx902;gfx904;gfx906;gfx908;gfx909;gfx1010;gfx1011;gfx1012;gfx1030;gfx1031;gfx1032 You might also need to change some code in `intern/cycles/device/hip/util.h` for everything to work properly. You can see an example in this commit on what sort of changes should be done: 2f89ddc043 It might actually be easier to test with the `cycles-hip-binaries` branch of Blender. This can be done by using `git checkout cycles-hip-binaries` in the Blender source code directory to checkout that branch then to compile a clean build of Blender from that. --- On a side note. There is a version of Blender avaliable for download with the HIP binaries pre-compiled. It should recognize a wide range of GPUs, but I have no idea if it's functional, you will probably experience some bugs, and this version of Blender will quickly become outdated so we do NOT accept bug reports for it: https://builder-uatest.blender.org/download/experimental/cycles-hip-binaries/ --- It should also be noted that at the current point in time Vega 64 isn't "officially" supported. It may work, but with the currently avaliable official Blender code Vega 64 isn't on the list of supported GPUs. It's also possible you may experience bugs due to the HIP implementation still being under development.
Author
Owner

We're not ready to have this tested by users, we don't know yet which architectures will work and may need to work through some bugs. When it's ready there will be build instructions.

@FogLizard In general for help building Blender, please use devtalk.blender.org. This task should stay on the topic of development, not support.

@Alaska, please don't recommend users to try that build, it's really not at a stage we want to deal with feedback from that.

We're not ready to have this tested by users, we don't know yet which architectures will work and may need to work through some bugs. When it's ready there will be build instructions. @FogLizard In general for help building Blender, please use devtalk.blender.org. This task should stay on the topic of development, not support. @Alaska, please don't recommend users to try that build, it's really not at a stage we want to deal with feedback from that.

Added subscriber: @MikePan

Added subscriber: @MikePan

Added subscriber: @Pliou

Added subscriber: @Pliou

Added subscriber: @Prodeous

Added subscriber: @Prodeous

Added subscriber: @SomeAB

Added subscriber: @SomeAB
  1. Good to see the progress on HIP. Haven't been using 3.0 Alpha/Beta because of lack of this. Can we expect support for Vega64, 56 generation of cards before official 3.0 release?

  2. What kind of performance numbers can be expected compared to before? OpenCL as far as I remember, was way behind even CUDA.. which is superseded by Optix on roughly equivalent hardware. As I have worked with HIP in machine learning before, I'm not very optimistic sadly.

1. Good to see the progress on HIP. Haven't been using 3.0 Alpha/Beta because of lack of this. Can we expect support for Vega64, 56 generation of cards before official 3.0 release? 2. What kind of performance numbers can be expected compared to before? OpenCL as far as I remember, was way behind even CUDA.. which is superseded by Optix on roughly equivalent hardware. As I have worked with HIP in machine learning before, I'm not very optimistic sadly.
Author
Owner

For questions and feedback, there is this topic now:
https://devtalk.blender.org/t/cycles-amd-hip-device-feedback/21400/16

I'll answer the question there, as this task is for coordinating development.

For questions and feedback, there is this topic now: https://devtalk.blender.org/t/cycles-amd-hip-device-feedback/21400/16 I'll answer the question there, as this task is for coordinating development.

Removed subscriber: @fire

Removed subscriber: @fire

Added subscriber: @brunnerh

Added subscriber: @brunnerh

Image texture size is limited, could detect this and resize or show user better error

If it is to resize automatically, there probably should be a warning mentioning the affected texture so it does not silently degrade the expected quality. Maybe there could be an option for it as well. E.g. In the context of a render farm it might be better to cancel with an error than render something of lesser quality the user did not want.

> Image texture size is limited, could detect this and resize or show user better error If it is to resize automatically, there probably should be a warning mentioning the affected texture so it does not silently degrade the expected quality. Maybe there could be an option for it as well. E.g. In the context of a render farm it might be better to cancel with an error than render something of lesser quality the user did not want.

Added subscriber: @ephraimpauli

Added subscriber: @ephraimpauli

Added subscriber: @Zeenus

Added subscriber: @Zeenus

Added subscriber: @AlfredENeuman

Added subscriber: @AlfredENeuman

Added subscriber: @dmlr7

Added subscriber: @dmlr7

Added subscriber: @Alirion-2

Added subscriber: @Alirion-2

Cant wait when this runs on Polaris. Hopefully stable rendering again. Still stuck on 2.8 for Stability.

Cant wait when this runs on Polaris. Hopefully stable rendering again. Still stuck on 2.8 for Stability.

Added subscriber: @itf

Added subscriber: @itf

Added subscriber: @Th3ho0d

Added subscriber: @Th3ho0d

can you share the list of the devices you working on enabling HIP for right now ? or a timeline for future devices to work on ?

can you share the list of the devices you working on enabling HIP for right now ? or a timeline for future devices to work on ?

In #91571#1267758, @Th3ho0d wrote:
can you share the list of the devices you working on enabling HIP for right now ? or a timeline for future devices to work on ?

RDNA and RDNA2 GPUs in linux for Blender 3.1
Other than that the only info we can give is that we plan to work backwards enabling older GPUs.

> In #91571#1267758, @Th3ho0d wrote: > can you share the list of the devices you working on enabling HIP for right now ? or a timeline for future devices to work on ? RDNA and RDNA2 GPUs in linux for Blender 3.1 Other than that the only info we can give is that we plan to work backwards enabling older GPUs.

Added subscriber: @LouisLithium

Added subscriber: @LouisLithium

Added subscriber: @hahnzhu

Added subscriber: @hahnzhu

Added subscriber: @Caden-Mitchell

Added subscriber: @Caden-Mitchell

Added subscriber: @Luciddream

Added subscriber: @Luciddream

Added subscriber: @iain.hogg

Added subscriber: @iain.hogg

In #91571#1267770, @BrianSavery wrote:

In #91571#1267758, @Th3ho0d wrote:
can you share the list of the devices you working on enabling HIP for right now ? or a timeline for future devices to work on ?

RDNA and RDNA2 GPUs in linux for Blender 3.1
Other than that the only info we can give is that we plan to work backwards enabling older GPUs.

Are you able to confirm how far backwords you are planning to work - Im running an AMD fireproW8100 - would it be likley that this would be included goinf fwd?

> In #91571#1267770, @BrianSavery wrote: >> In #91571#1267758, @Th3ho0d wrote: >> can you share the list of the devices you working on enabling HIP for right now ? or a timeline for future devices to work on ? > > RDNA and RDNA2 GPUs in linux for Blender 3.1 > Other than that the only info we can give is that we plan to work backwards enabling older GPUs. Are you able to confirm how far backwords you are planning to work - Im running an AMD fireproW8100 - would it be likley that this would be included goinf fwd?
Member

In #91571#1279918, @iain.hogg wrote:

In #91571#1267770, @BrianSavery wrote:

RDNA and RDNA2 GPUs in linux for Blender 3.1
Other than that the only info we can give is that we plan to work backwards enabling older GPUs.

Are you able to confirm how far backwords you are planning to work - Im running an AMD fireproW8100 - would it be likley that this would be included goinf fwd?

Note: From my interprestaion of things, ROCm is required to run HIP on Linux.
This is just my interpretation of things and I may be getting it wrong. According to some documentation for ROCm on Linux, ROCm officially supports graphics cards going back to Vega (56 and 64). ROCm is enabled, but is not officially support on graphics cards going back to the "Hawaii" chips such as AMD Radeon R9 390X and FirePro W9100.

Assuming this trend carries over to the HIP implementation in Blender, then it is unlikely your GPU (AMD fireproW8100) will be supported. But this is all just specualtion ffrom me and I may be wrong.

> In #91571#1279918, @iain.hogg wrote: >> In #91571#1267770, @BrianSavery wrote: >> >> RDNA and RDNA2 GPUs in linux for Blender 3.1 >> Other than that the only info we can give is that we plan to work backwards enabling older GPUs. > > Are you able to confirm how far backwords you are planning to work - Im running an AMD fireproW8100 - would it be likley that this would be included goinf fwd? Note: From my interprestaion of things, ROCm is required to run HIP on Linux. This is just my interpretation of things and I may be getting it wrong. According to some documentation for ROCm on Linux, ROCm officially supports graphics cards going back to Vega (56 and 64). ROCm is enabled, but is not officially support on graphics cards going back to the "Hawaii" chips such as AMD Radeon R9 390X and FirePro W9100. Assuming this trend carries over to the HIP implementation in Blender, then it is unlikely your GPU (AMD fireproW8100) will be supported. But this is all just specualtion ffrom me and I may be wrong.

Cannot GPU compute in Blender 3 alpha in Linux. I have ROCm and HIP installed. I can compute render in 2.93 but my device doesn’t even show up in Blender 3. Radeon RX5700 XT.

Cannot GPU compute in Blender 3 alpha in Linux. I have ROCm and HIP installed. I can compute render in 2.93 but my device doesn’t even show up in Blender 3. Radeon RX5700 XT.
Member

In #91571#1280590, @Caden-Mitchell wrote:
Cannot GPU compute in Blender 3 alpha in Linux. I have ROCm and HIP installed. I can compute render in 2.93 but my device doesn’t even show up in Blender 3. Radeon RX5700 XT.

HIP support in Linux is still being worked up. New drivers and/or a new HIP compiler is needed for it to work properly.

> In #91571#1280590, @Caden-Mitchell wrote: > Cannot GPU compute in Blender 3 alpha in Linux. I have ROCm and HIP installed. I can compute render in 2.93 but my device doesn’t even show up in Blender 3. Radeon RX5700 XT. HIP support in Linux is still being worked up. New drivers and/or a new HIP compiler is needed for it to work properly.

Added subscriber: @Hannah-Umit

Added subscriber: @Hannah-Umit

Added subscriber: @not_a_boring_name

Added subscriber: @not_a_boring_name

Added subscriber: @Maxzor

Added subscriber: @Maxzor

Added subscriber: @Jonas-Hagberth

Added subscriber: @Jonas-Hagberth

This comment was removed by @Jonas-Hagberth

*This comment was removed by @Jonas-Hagberth*

Added subscriber: @Baardaap

Added subscriber: @Baardaap

Added subscriber: @dvi

Added subscriber: @dvi

when is Hardware ray-tracing coming?

when is Hardware ray-tracing coming?

Regarding Linux support:

Our driver release timeline unfortunately doesn't quite line up with the dates for Blender 3.1, and there are some fixes in there that are needed. It should be out sometime after bcon3 and before bcon4, but I'm proposing Linux support gets pushed to Blender 3.2 so there is time for testing. Linux users should be able to use it under 3.2 in march though.

Regarding Linux support: Our driver release timeline unfortunately doesn't quite line up with the dates for Blender 3.1, and there are some fixes in there that are needed. It should be out sometime after bcon3 and before bcon4, but I'm proposing Linux support gets pushed to Blender 3.2 so there is time for testing. Linux users should be able to use it under 3.2 in march though.
Author
Owner

Ok, we can push it to 3.2 then. There will be a 3.2 daily build starting next week, so as soon as there is something working it can be available to users for testing.

Ok, we can push it to 3.2 then. There will be a 3.2 daily build starting next week, so as soon as there is something working it can be available to users for testing.
Member

Is there a branch for 3.2 or is code going to master for now? I have some changes to hipew, I'd like to push

Is there a branch for 3.2 or is code going to master for now? I have some changes to hipew, I'd like to push
Author
Owner

There will be a branch next week. But code can go into master still.

There will be a branch next week. But code can go into master still.

Removed subscriber: @AlfredENeuman

Removed subscriber: @AlfredENeuman

Added subscriber: @Garek

Added subscriber: @Garek

Added subscriber: @Maxzor-1

Added subscriber: @Maxzor-1

Added subscriber: @ThomasDinges

Added subscriber: @ThomasDinges

@ThomasDinges Hello, what about dedicating some time in your next weekly interaction meeting to talk about it? My interest is to get technical on HIP support, I have been helping packaging ROCm for Debian/Ubuntu and this is practically finished.

@ThomasDinges Hello, what about dedicating some time in your next weekly interaction meeting to talk about it? My interest is to get technical on HIP support, I have been helping packaging ROCm for Debian/Ubuntu and this is practically finished.
Contributor

Removed subscriber: @IyadAhmed

Removed subscriber: @IyadAhmed

Could we get a legacy OpenCL pipeline option back for Linux only (or even HIP unsupported AMD cards)? I don't know if the new Cycles code is compatible with OpenCL, but I am not satisfied with the state of Blender 3.x on my AMD system currently.

Could we get a legacy OpenCL pipeline option back for Linux only (or even HIP unsupported AMD cards)? I don't know if the new Cycles code is compatible with OpenCL, but I am not satisfied with the state of Blender 3.x on my AMD system currently.

Added subscriber: @CadenMitchell-3

Added subscriber: @CadenMitchell-3

I am not satisfied with the state of Blender 3.x on my AMD system currently.

@CadenMitchell-3 I 100% Agree with this part. OpenCL is a different story as it's very much broken but I doubt that the amount of Linux users using HIP compatible devices is as big as the current GCN userbase.

> I am not satisfied with the state of Blender 3.x on my AMD system currently. @CadenMitchell-3 I 100% Agree with this part. OpenCL is a different story as it's very much broken but I doubt that the amount of Linux users using HIP compatible devices is as big as the current GCN userbase.

This comment was removed by @2905710881

*This comment was removed by @2905710881*

In #91571#1294857, @Hannah-Umit wrote:

I am not satisfied with the state of Blender 3.x on my AMD system currently.

@CadenMitchell-3 I 100% Agree with this part. OpenCL is a different story as it's very much broken but I doubt that the amount of Linux users using HIP compatible devices is as big as the current GCN userbase.

The underlying layer of hip is rocm, the old gcn graphics card has long supported rocm, rdna graphics card support time almost and cyclesx hip is synchronized support, so gcn support hip is only a matter of time.

> In #91571#1294857, @Hannah-Umit wrote: >> I am not satisfied with the state of Blender 3.x on my AMD system currently. > > > @CadenMitchell-3 I 100% Agree with this part. OpenCL is a different story as it's very much broken but I doubt that the amount of Linux users using HIP compatible devices is as big as the current GCN userbase. The underlying layer of hip is rocm, the old gcn graphics card has long supported rocm, rdna graphics card support time almost and cyclesx hip is synchronized support, so gcn support hip is only a matter of time.

Please keep this task on topic! This task is for developers and should focus on code discussion. Please refrain from further user questions, including asking for a build, asking for a merge ETA, examples, comparison with other software and so on... Thank you for your understanding.

Every further off-topic comment will be removed.

Please keep this task on topic! This task is for developers and should focus on code discussion. Please refrain from further user questions, including asking for a build, asking for a merge ETA, examples, comparison with other software and so on... Thank you for your understanding. Every further off-topic comment will be removed.

Added subscriber: @Obsyden

Added subscriber: @Obsyden

The crash on Linux is caused by the hipDeviceGetAttribute function, which will always segfault for some mysterious reason. Fortunately, this can be replaced with hipGetDeviceProperties for the exact same information that the former fetches.

The crash on Linux is caused by the hipDeviceGetAttribute function, which will always segfault for some mysterious reason. Fortunately, this can be replaced with hipGetDeviceProperties for the exact same information that the former fetches.

Having the above function not crashing is rather trivial, what matters is the graphics/compute interop being implemented - and between which APIs - underneath or not?

Having the above function not crashing is rather trivial, what matters is the graphics/compute interop being implemented - and between which APIs - underneath or not?
Author
Owner

If just using hipGetDeviceProperties works that would be great, but from what I understand there are further issues.

Graphics interop is not that important, it improves viewport performance but everything still works without it.

If just using hipGetDeviceProperties works that would be great, but from what I understand there are further issues. Graphics interop is not that important, it improves viewport performance but everything still works without it.

Added subscriber: @Takuro-Shoji

Added subscriber: @Takuro-Shoji

Added subscriber: @mkaito

Added subscriber: @mkaito

Added subscriber: @BlenderUser700

Added subscriber: @BlenderUser700

This comment was removed by @BlenderUser700

*This comment was removed by @BlenderUser700*

I just made a diff to fix the Linux crash due to hipDeviceGetAttribute, but there are still other crashes due to causes unknown to me. Keep in mind it's my first patch on this repo: https://developer.blender.org/D14198

I just made a diff to fix the Linux crash due to hipDeviceGetAttribute, but there are still other crashes due to causes unknown to me. Keep in mind it's my first patch on this repo: https://developer.blender.org/D14198

After some testing I've found that cycles HIP instantly crashes when using image textures of any kind. The error thrown is

Memory access fault by GPU node-1 (Agent handle: 0x7fffb0ae5000) on address (nil). Reason: Page not present or supervisor privilege.

I'm running Ubuntu 20.04 LTS with a Radeon RX 6600 XT.
The only steps to reproduce this are going into any material e.g. environment or materials tab and selecting some form of image texture like environment texture or image texture. This instantly crashes Blender with the above error

After some testing I've found that cycles HIP instantly crashes when using image textures of any kind. The error thrown is ``` Memory access fault by GPU node-1 (Agent handle: 0x7fffb0ae5000) on address (nil). Reason: Page not present or supervisor privilege. ``` I'm running Ubuntu 20.04 LTS with a Radeon RX 6600 XT. The only steps to reproduce this are going into any material e.g. environment or materials tab and selecting some form of image texture like environment texture or image texture. This instantly crashes Blender with the above error

Added subscriber: @Yuro

Added subscriber: @Yuro

Added subscriber: @george-4

Added subscriber: @george-4

Added subscriber: @Noah-Prezant

Added subscriber: @Noah-Prezant

This issue was referenced by 179100c021

This issue was referenced by 179100c021269c278396c9a8039a0b75703c5f3a

Added subscriber: @Kosmita

Added subscriber: @Kosmita

Added subscriber: @DavidG-1

Added subscriber: @DavidG-1

Added subscriber: @niobium93

Added subscriber: @niobium93

I'm running Arch Linux with ROCm 5.1.1 installed with a Radeon RX 5700 XT and am getting the same crash whenever any image texture exists in the scene. Complex scenes render fine only as long as all image textures are removed.
blender.crash.txt

I'm running Arch Linux with ROCm 5.1.1 installed with a Radeon RX 5700 XT and am getting the same crash whenever any image texture exists in the scene. Complex scenes render fine only as long as all image textures are removed. [blender.crash.txt](https://archive.blender.org/developer/F13071836/blender.crash.txt)

Added subscriber: @Darkhan-K

Added subscriber: @Darkhan-K

I upgraded to ROCm 5.1.3 and blender 3.3.r115176.gffa262c9f8c and now the HIP kernel fails to compile. blender hip compile fail.log

I upgraded to ROCm 5.1.3 and blender 3.3.r115176.gffa262c9f8c and now the HIP kernel fails to compile. [blender hip compile fail.log](https://archive.blender.org/developer/F13101224/blender_hip_compile_fail.log)
Member

@niobium93 , please make a separate bug report for your issues rather than commenting them on this task.

@niobium93 , please make a separate bug report for your issues rather than commenting them on this task.

Removed subscriber: @Low_Polygon42

Removed subscriber: @Low_Polygon42

Removed subscriber: @Hannah-Umit

Removed subscriber: @Hannah-Umit

Added subscriber: @CosmoHQ

Added subscriber: @CosmoHQ

Added subscriber: @Pavel_Patzelt

Added subscriber: @Pavel_Patzelt

Removed subscriber: @FreeCX

Removed subscriber: @FreeCX

Added subscriber: @Neil-McNair

Added subscriber: @Neil-McNair

This issue was referenced by abfa09752f

This issue was referenced by abfa09752f5c4d1fa2ae9df5e4ee0c9d77b50f3e

Removed subscriber: @Baardaap

Removed subscriber: @Baardaap

Added subscriber: @finalflasher

Added subscriber: @finalflasher

Added subscriber: @PoramaRuengrairatanaroj

Added subscriber: @PoramaRuengrairatanaroj

Added subscriber: @Jonathan-61

Added subscriber: @Jonathan-61

Who actually tested and checked the box for "RDNA2" under "Linux support and stability"?
At least the viewport does not work properly on HIP+Cycles as reported here:
https://developer.blender.org/T100353
and here:
https://gitlab.freedesktop.org/drm/amd/-/issues/2145

Who actually tested and checked the box for "RDNA2" under "Linux support and stability"? At least the viewport does not work properly on HIP+Cycles as reported here: https://developer.blender.org/T100353 and here: https://gitlab.freedesktop.org/drm/amd/-/issues/2145
Author
Owner

This task is not used to track bugs, it's only for the initial development of features where RDNA2 was confirmed to work. Bugs discovered afterwards or with specific distribution/driver combinations like the one you mentioned are handled in their own task..

This task is not used to track bugs, it's only for the initial development of features where RDNA2 was confirmed to work. Bugs discovered afterwards or with specific distribution/driver combinations like the one you mentioned are handled in their own task..

Added subscriber: @L-S

Added subscriber: @L-S

In #91571#1458697, @brecht wrote:
This task is not used to track bugs, it's only for the initial development of features where RDNA2 was confirmed to work. Bugs discovered afterwards or with specific distribution/driver combinations like the one you mentioned are handled in their own task..

Apologies for responding in the incorrect task. This may be wishful thinking but it appears you to have gone out of your way to mention "specific distribution/driver combinations" in your response. By any chance are you are aware of a combination Blender and HIP that does not produce the fault in #100353. If so please let us know so we can report it to the drm/amd issue, it could be pivotal in finding a resolution. Thanks!

> In #91571#1458697, @brecht wrote: > This task is not used to track bugs, it's only for the initial development of features where RDNA2 was confirmed to work. Bugs discovered afterwards or with specific distribution/driver combinations like the one you mentioned are handled in their own task.. Apologies for responding in the incorrect task. This may be wishful thinking but it appears you to have gone out of your way to mention "specific distribution/driver combinations" in your response. By any chance are you are aware of a combination Blender and HIP that does not produce the fault in #100353. If so please let us know so we can report it to the drm/amd issue, it could be pivotal in finding a resolution. Thanks!

Added subscriber: @HowardBlandy

Added subscriber: @HowardBlandy

Added subscriber: @Cosmocrat

Added subscriber: @Cosmocrat
Brecht Van Lommel added this to the Render & Cycles project 2023-02-07 19:08:06 +01:00
Philipp Oeser removed the
Interest
Render & Cycles
label 2023-02-09 14:02:59 +01:00
Member
  • Clip mode in Image Texture node not supported (#92975)

Using HIP SDK 5.5 to compile HIP kernels, and early 2024 GPU drivers on a RX 7800XT on Windows, it seems this issue has been fixed (assuming you modify the relevant code to use the clip mode).

I don't know when this was fixed, whether or not it was a ROCm and/or driver fix, or how to write the relevant code to detect different ROCm/driver versions in device_impl to switch between the working case, and the "fallback" case. So can someone else with the relevant knowledge handle this code change? CC @brecht or @salipour

> - [ ] Clip mode in Image Texture node not supported (#92975) Using HIP SDK 5.5 to compile HIP kernels, and early 2024 GPU drivers on a RX 7800XT on Windows, it seems this issue has been fixed (assuming you [modify the relevant code](https://projects.blender.org/blender/blender/pulls/118540/files) to use the clip mode). I don't know when this was fixed, whether or not it was a ROCm and/or driver fix, or how to write the relevant code to detect different ROCm/driver versions in `device_impl` to switch between the working case, and the "fallback" case. So can someone else with the relevant knowledge handle this code change? CC @brecht or @salipour
Author
Owner

Thanks for testing that. I'm not sure how to find out in which driver release this get fixed, @salipour, do you know? Besides installing old drivers until it breaks.

Thanks for testing that. I'm not sure how to find out in which driver release this get fixed, @salipour, do you know? Besides installing old drivers until it breaks.
Contributor

I don't know the exact driver version but the issue has been fixed for a long time now
https://github.com/ROCm/HIP/pull/2229

I don't know the exact driver version but the issue has been fixed for a long time now https://github.com/ROCm/HIP/pull/2229
Author
Owner

Ok, let's just enable it everywhere then without a check.

@Alaska feel free to make a PR, if not I can do it.

Ok, let's just enable it everywhere then without a check. @Alaska feel free to make a PR, if not I can do it.
Member
  • Graphics interop is broken in 21.Q4 driver, enable for next driver (D13167)

On a RX 7800XT with early 2024 drivers on Windows with the relevant code changes (Pull request: #118562), OpenGL interop appears to be working. I see none of the issues reported in #92972

Similar to the HIP Clip issue. I'm not sure when this was fixed, but it seems like it was probably over a year ago considering that AMD has OpenGL interop examples with Windows support dating back to December 2022. And I would presume AMD verify this example worked before publishing it.

> - [ ] Graphics interop is broken in 21.Q4 driver, enable for next driver (D13167) On a RX 7800XT with early 2024 drivers on Windows with the relevant code changes (Pull request: #118562), OpenGL interop appears to be working. I see none of the issues reported in #92972 Similar to the HIP Clip issue. I'm not sure when this was fixed, but it seems like it was probably over a year ago considering that AMD has [OpenGL interop examples](https://github.com/amd/rocm-examples/tree/develop/HIP-Basic/opengl_interop) with Windows support dating back to December 2022. And I would presume AMD verify this example worked before publishing it.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
73 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#91571
No description provided.