blender/blender

I18n: disambiguate and extract a few messages #111146

Merged

Bastien Montagne merged 3 commits from pioverfour/blender:dp_disambiguate into main

2023-09-04 16:16:36 +02:00

Damien Picard commented

2023-08-15 18:54:50 +02:00

Member

This commit disambiguates the following messages:

Sequencer effect strip types: use "Sequence" context in relevant
places, as that is already extracted as part of the
sequencer_prop_effect_types enum, and more specific.
"Language" (a natural or programming language)
"Flat" (gender)
"Smooth" (action or amount -- very partial disambiguation for now
because this is all over the place)

It also extracts these messages:

Newly created Freestyle data
- LineStyle
- LineSet
- Modifiers
"Registering panel class:" error message from RNA registration
"Node must be run as tool" error message from tool geometry nodes

This commit disambiguates the following messages: - Sequencer effect strip types: use "Sequence" context in relevant places, as that is already extracted as part of the `sequencer_prop_effect_types` enum, and more specific. - "Language" (a natural or programming language) - "Flat" (gender) - "Smooth" (action or amount -- very partial disambiguation for now because this is all over the place) It also extracts these messages: - Newly created Freestyle data - LineStyle - LineSet - Modifiers - "Registering panel class:" error message from RNA registration - "Node must be run as tool" error message from tool geometry nodes Ref #43295

Damien Picard added the

labels 2023-08-15 18:54:50 +02:00

Damien Picard requested review from Bastien Montagne 2023-08-15 18:55:05 +02:00

~~Damien Picard referenced this pull request 2023-08-15 18:57:38 +02:00~~

Translation disambiguation requests #43295

Bastien Montagne requested changes 2023-08-21 16:43:30 +02:00

Bastien Montagne left a comment

Owner

Generally LGTM, some minor comments below.

Generally LGTM, some minor comments below.

source/blender/blentranslation/BLT_translation.h Outdated

						
				@ -197,6 +198,7 @@ typedef struct {

				        BLT_I18NCONTEXTS_ITEM(BLT_I18NCONTEXT_ID_WORKSPACE, "id_workspace"), \

				        BLT_I18NCONTEXTS_ITEM(BLT_I18NCONTEXT_ID_WORLD, "id_world"), \

				        BLT_I18NCONTEXTS_ITEM(BLT_I18NCONTEXT_EDITOR_FILEBROWSER, "editor_filebrowser"), \

				        BLT_I18NCONTEXTS_ITEM(BLT_I18NCONTEXT_EDITOR_PREFERENCES, "editor_preferences"), \

Bastien Montagne commented

2023-08-21 16:43:15 +02:00

Owner

See comment where it's used, think this is not needed.

See comment where it's used, think this is not needed.

source/blender/makesrna/intern/rna_userdef.cc Outdated

						
				@ -5135,6 +5135,7 @@ static void rna_def_userdef_view(BlenderRNA *brna)

				      prop, "rna_lang_enum_properties_get_no_international", nullptr, nullptr);

				#  endif

				  RNA_def_property_ui_text(prop, "Language", "Language used for translation");

				  RNA_def_property_translation_context(prop, BLT_I18NCONTEXT_EDITOR_PREFERENCES);

Bastien Montagne commented

2023-08-21 16:42:50 +02:00

Owner

I really do not think a new context for this case is worth it... Could use instead e.g. some UI-related ID context, like BLT_I18NCONTEXT_ID_WINDOWMANAGER?

I really do not think a new context for this case is worth it... Could use instead e.g. some UI-related ID context, like `BLT_I18NCONTEXT_ID_WINDOWMANAGER`?

Damien Picard commented

2023-09-03 19:03:06 +02:00

Author

Member

Although I understand that that is not what the system is currently designed to solve, I still try finding contexts that will make sense to translators, and I don’t think "WindowManager" does that.

But I will change to that if you request it.

Although I understand that that is not what the system is currently designed to solve, I still try finding contexts that will make sense to translators, and I don’t think "WindowManager" does that. But I will change to that if you request it.

Bastien Montagne commented

2023-09-04 10:28:22 +02:00

Owner

Thing is. 'user preferences' is not a really good context either... This is related to UI, so we could have a 'UI' context, but imho 'window manager' is a good 'synonym' to UI, since UI is the only role of that ID...

Thing is. 'user preferences' is not a really good context either... This is related to UI, so we could have a 'UI' context, but imho 'window manager' is a good 'synonym' to UI, since UI is the only role of that ID...

Damien Picard commented

2023-09-04 14:22:28 +02:00

Author

Member

Actually, I just retested and this is not going to work anyway, because the language names are extracted in another way, and are used from different places.
It will be easier to actually leave them with the default context, and add a context to messages meaning “programming language”.

Actually, I just retested and this is not going to work anyway, because the language names are extracted in another way, and are used from different places. It will be easier to actually leave them with the default context, and add a context to messages meaning “programming language”.

Damien Picard commented

2023-09-04 15:01:01 +02:00

Author

Member

Ok so I went with adding a “Python console” context to refer to the programming instances. I hope that’s all right, I again couldn’t see an existing context that really made sense…

Ok so I went with adding a “Python console” context to refer to the programming instances. I hope that’s all right, I again couldn’t see an existing context that really made sense…

source/blender/sequencer/intern/utils.cc Outdated

						
				@ -122,3 +122,3 @@

				      return DATA_("Audio");

				    case SEQ_TYPE_CROSS:

				      return DATA_("Cross");

				      return CTX_DATA_(BLT_I18NCONTEXT_ID_SEQUENCE, "Cross");

Bastien Montagne commented

2023-08-21 16:42:03 +02:00

Owner

Why do the above ones not need the sequence context too?

Why do the above ones not need the `sequence` context too?

pioverfour marked this conversation as resolved

Bastien Montagne commented

2023-08-21 16:43:52 +02:00

Owner

@blender-bot build

@blender-bot build

Damien Picard force-pushed dp_disambiguate from 8b40e2a396 to cabc4aa3a5

2023-09-03 19:12:42 +02:00

Compare

Damien Picard added 1 commit 2023-09-04 14:13:08 +02:00

Replace Preferences context with WindowManager 88af54e822

Damien Picard added 1 commit 2023-09-04 14:59:16 +02:00

Disambiguate "Language" with new Python console context

buildbot/vexp-code-patch-coordinator Build done.

Details

Bastien Montagne approved these changes 2023-09-04 15:14:33 +02:00

Bastien Montagne left a comment

Owner

Eeh, still adding one more context in the end... But think this one makes sense then. thanks for all the fixes!

Eeh, still adding one more context in the end... But think this one makes sense then. thanks for all the fixes!

Bastien Montagne commented

2023-09-04 15:14:46 +02:00

Owner

@blender-bot build

@blender-bot build

Bastien Montagne referenced this issue from a commit

2023-09-04 16:16:35 +02:00

I18n: disambiguate and extract a few messages

Bastien Montagne merged commit 564bbdf6e7 into main

2023-09-04 16:16:36 +02:00

Bastien Montagne deleted branch dp_disambiguate

2023-09-04 16:16:38 +02:00

Stefan Werner referenced this issue from a commit

2023-09-07 15:02:38 +02:00

I18n: disambiguate and extract a few messages

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111146

No description provided.