blender-v3.3-release backports #112325

Philipp Oeser · 2023-09-13T14:04:50+02:00

Philipp Oeser commented

2023-09-13 14:04:50 +02:00

No response

_No response_

Philipp Oeser added 12 commits 2023-09-13 14:05:02 +02:00

2d482f482a Fix building Blender with some versions of gcc.

Seems like quadriflow was missing a header, which somehow made the build
fails on Suse Tumbleweed (gcc 13).

a66d09f2b5 Fix T103960: build issue with GCC 13 in Cycles thread code

9d9db7852d Fix (partially) wrong RNA path for 'ViewShading' data.

This commit fixes the RNA path reported from the struct owned by the
Scene.display data. Paths generated for the View3D space remain
completely broken (but whole 'space' paths are broken anyway).

1cdd83bf9d Fix #110085 : Ignore Scroller Zone when on a Screen Edge

When the mouse cursor is between editors ignore scroller zones, which
overflow their areas, so that screen edges are always detected.

Pull Request: #110402

da6c1e1ccf Fix #110723 : cant drop object name on object field/socket in node editor

Reason was a difference in poll functions (dropbox poll function vs.
operator poll function).

So the dropbox was actually recognized as being active (see
`dropbox_active`) but then when actually dropping, the corresponding
operator wasnt called (but instead another operator was).

In detail, the way `wm_handlers_do_intern` works, it checks all
dropboxes poll function if one succeeds it calls the dropbox operator.
But if that operators poll function fails, `wm_handlers_do_intern`
happily continues and "ends" the drop operations in a way we dont
actually get to the "real" dropbox & operator that was also recognized
as being active.

In the case of the report:
- dropbox for `UI_OT_drop_name` is active
- dropbox poll for `NODE_OT_add_object` (`node_object_drop_poll`)
succeeds though
- operator poll for `NODE_OT_add_object` (`node_add_object_poll`) fails
(it checks `UI_but_active_drop_name` already)

So in order to make this work, add the check for `UI_but_active_drop_name` to two dropbox poll
functions (and remove from the operator polls).

Probably good for LTS as well.

Pull Request: #110929

ee2e231adc Fix #111277 : NaN in Vector Displacement leading to render errors

Fixes NaN in Vector Displacement node caused by the normalization of
0, 0, 0 vectors.

This fixes both visual rendering issues and an "illegal address" error
on the GPU. The "illegal address" error came from the Light Tree
Sampling code not handling the NaN normals well, leading to weird code
paths being taken, eventually leading to a kernel_assert and a
user facing illegal address error.

In Blender 3.5+, this fixes two errors (visual artifacts and errors on
the GPU when using the light tree). In Blender 3.3 it only fixes one
(visual artifacts) because 3.3 doesn't have the light tree. The commit
message should be adjusted to represent that

Pull Request: #111294

5eafbc7c6e Fix #111238 : Arrow keys in some menus work in the opposite direction

Since menus are created flipped (from event handling point of view), the
root layout block needs to be flagged `UI_BLOCK_IS_FLIP`.
This was missing for a couple of `uiMenuCreateFunc`, namely:
- creating worspaces menu
- modifiers extra ops
- constraints extra ops
- GP modifiers extra ops
- GP Shader FX extra ops

Same fix as f51de2246c.

Not crtitcal, but could go into LTS I guess.

Pull Request: #111341

a423ebad48 Fix #94129 : Unable to remove added keying set from context menu

Mistake in (7-year-old) f6c09eadf0.

The operator was just cancelled if the right button was found, instead
it should only cancel if the button is _not_ found.

Pull Request: #111373

895702f803 Fix #109427 : Shortcut missing in animation editors channel context menu

Specifying the correct operator context (`INVOKE_REGION_CHANNELS` in
this case) is mandatory, otherwise looking up the shortcut in
`wm_keymap_item_find_props` will fetch the wrong region
(`RGN_TYPE_WINDOW` not `RGN_TYPE_CHANNELS`) and thus wont find the keymap
item in that region keymap.

This was already done for the other menus, not for the context menu
though.

Pull Request: #111376

b4a34d54f7 Fix #111642 : VSE glow code can overflow with small proxies

With such small proxy sizes (combined with a small blur radius), the
kernels `halfWidth` can get zero, which leads to a memory allocation of
same zero size and writing to that memory leads to overflow/crashes/can
only go downhill from there.

Now early out in such cases [which leads to
slightly different output -- well if the "buggy" output survives and
does not crash that is].

(alternatively we could just prevent the overflow and still let do
`RVBlurBitmap2_float` do stuff that it really shouldnt imo, see first version of the PR)

Pull Request: #111660

662fd4213c Fix #112208 : Vertex parenting index wrong with multiple splines

Caused by 346023b457.

Above commit made variables too local (starting index with zero in each
nurb of the curve/surface object, but we need the "overall" index).

Should be good for LTS.

Pull Request: #112222

buildbot/vexp-code-patch-coordinator Build done. Details

6cdff49851 Fix #112144 : Graph Editor handle highlighting not working correctly

Mistake in 7c48196056.

Second handle was always drawn with positions of the first handle (when
it was highlighted).

Should be good for 3.6/3.3 LTS.

Pull Request: #112219

Philipp Oeser commented

2023-09-13 14:05:34 +02:00

@blender-bot build

Philipp Oeser merged commit f7e6ddb993 into blender-v3.3-release

2023-09-13 14:29:57 +02:00

Philipp Oeser referenced this issue from a commit

2023-09-13 14:29:58 +02:00

Fix #112144: Graph Editor handle highlighting not working correctly

Philipp Oeser deleted branch blender-v3.3-release

2023-09-13 14:29:59 +02:00

Sign in to join this conversation.

No reviewers