Nathan Vegdahl nathanvegdahl
  • Amsterdam, Netherlands
  • https://cessen.com
  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Nathan Vegdahl commented on pull request blender/blender#111775 2023-09-01 13:54:18 +02:00
Fix #111711: bone collection visibility cannot be overridden

Visibility ON/OFF

Oooooh, got it. I misunderstood the other part of the description. I thought "Since the switch from bone layers to bone collections in 998136f7a7, visibility could not be…

Nathan Vegdahl pushed to main at nathanvegdahl/blender 2023-09-01 12:33:22 +02:00
d361d67e11 Fix: Cursor wrapping in Graph Editor slider operators
3ac5b64b20 Cleanup: remove unnecessary functions from public bake api
7df19cfa67 Cleanup: remove unnecessary file
67bb0bd1a5 Cleanup: remove unused code
b45dd4cfac EEVEE: change Principled BSDF to match Cycles
Compare 214 commits »
Nathan Vegdahl commented on issue blender/blender#111711 2023-09-01 12:26:58 +02:00
Unable to show/hide bone collection on library override armature

Ah, only comes over if some bone was actually assigned to that group (is this intended?)

Only bring over layers with bones on them was intentional and makes sense. Simply carrying over…

Nathan Vegdahl commented on pull request blender/blender#111775 2023-09-01 12:15:01 +02:00
Fix #111711: bone collection visibility cannot be overridden

It looks good to me, and works as expected in my testing. I'm not familiar enough with overrides yet to feel confident signing off on this, so I'll leave that to @mont29 and/or @dr.sybren

Nathan Vegdahl commented on issue blender/blender#111776 2023-09-01 11:34:45 +02:00
Bone layers/groups from 3.6 get lost after save/reload when linked/saved in 4.0

This sounds like something @Hjalti and I discovered the other day, but hadn't gotten around to filing an issue about yet. Basically, if you have scene file A and rig file B, both created in…

Nathan Vegdahl opened issue blender/blender#111780 2023-09-01 10:58:08 +02:00
Bone collections and bone collection membership are not handled properly when undoing in armature edit mode
Nathan Vegdahl commented on issue blender/blender#111553 2023-08-31 17:38:19 +02:00
Blender 4.0.0 - Armature Rig with IK broken

Minimal repro: 111553_minimal_repro.blend

The issue appears to be triggered by having two IK constraints on the same bone, with the first…

Nathan Vegdahl pushed to main at blender/blender 2023-08-31 16:27:04 +02:00
daa4c0f91e Fix: set default bone collection active
Nathan Vegdahl merged pull request blender/blender#111733 2023-08-31 16:27:04 +02:00
Bone collection: Set first collection active
Nathan Vegdahl approved blender/blender#111733 2023-08-31 16:25:23 +02:00
Bone collection: Set first collection active

Looks good to me. Thanks!

Nathan Vegdahl approved blender/blender#111745 2023-08-31 16:21:09 +02:00
Fix: Blend to Ease keyframes property name

Looks good to me!

Nathan Vegdahl approved blender/blender#111735 2023-08-31 16:18:56 +02:00
Animation: Shear operator for Graph Editor

Looks good to me!

Nathan Vegdahl commented on pull request blender/blender#111510 2023-08-31 16:16:37 +02:00
Refactor: Rename functions and structs in keyframes_draw.cc

This generally looks good to me, and certainly reads a lot more clearly. I agree with the notes from @filedescriptor, and had one additional suggestion that might be out of scope for this PR.

Nathan Vegdahl commented on pull request blender/blender#111510 2023-08-31 16:13:34 +02:00
Refactor: Rename functions and structs in keyframes_draw.cc

Not sure how deep the renaming rabbit hole would go, but could agroup be expanded? It's not immediately clear what that is (action group? animation group?).

Nathan Vegdahl commented on pull request blender/blender#111510 2023-08-31 16:07:20 +02:00
Refactor: Rename functions and structs in keyframes_draw.cc

Agreed. When I first read the function name, I thought, "GNU Public License channel...?" Of course, I knew that's not what it would be, but it wasn't immediately clear what it was.

Since the…

Nathan Vegdahl suggested changes for blender/blender#111735 2023-08-31 15:35:51 +02:00
Animation: Shear operator for Graph Editor

The code looks good to me. Just some nits about naming and word usage.

Nathan Vegdahl commented on pull request blender/blender#111735 2023-08-31 15:35:50 +02:00
Animation: Shear operator for Graph Editor

Shear is a linear operation, so talking about curves and bending feels misleading to me. When I first read this I honestly thought, "Wait, is there a third parameter that adds curvature on top of the shear?"

Nathan Vegdahl commented on pull request blender/blender#111735 2023-08-31 15:35:50 +02:00
Animation: Shear operator for Graph Editor

Is lineal a typo? Or just a term I'm not familiar with?

Nathan Vegdahl merged pull request blender/blender#111723 2023-08-31 15:12:34 +02:00
Fix: Bone collection renaming when empty string
Nathan Vegdahl pushed to main at blender/blender 2023-08-31 15:12:34 +02:00
c75d6ae0ed Fix: Bone collection renaming when empty string