Brian Savery (AMD) BrianSavery
  • Joined on 2016-11-16
Brian Savery (AMD) commented on issue blender/blender#100353 2023-05-04 23:51:56 +02:00
Cycles HIP rendered viewport crashes system/GPU on Linux with RDNA2 GPU

We've tested with 3.6. Still see the issue on 3.5, but should be fixed in 3.6.

@brecht have we enabled 3.6 builds with the new rocm 5.5 compiler?

Brian Savery (AMD) commented on pull request BogdanNagirniak/blender#34 2023-05-03 18:52:57 +02:00
Need to do the same light power as Cycles in Watts for Hydra RPR

This seems like a strange value. How was this found?

Brian Savery (AMD) commented on pull request BogdanNagirniak/blender#34 2023-05-03 18:52:57 +02:00
Need to do the same light power as Cycles in Watts for Hydra RPR

the name here is strange. Maybe "radius_threshold". And please add a comment why.

Brian Savery (AMD) commented on pull request blender/blender#105538 2023-05-03 17:35:12 +02:00
Cycles: HIP-RT for AMD hardware ray-tracing

For users wanting to test this, Please use the driver here: https://www.amd.com/en/support/kb/release-notes/rn-rad-win-22-40-51-06-blender-3-6-beta

Brian Savery (AMD) approved BogdanNagirniak/blender#30 2023-04-27 23:09:50 +02:00
Fix wrong path for PXR_MTLX_STDLIB_SEARCH_PATHS

Still think this could be cleaner, I would do

Brian Savery (AMD) commented on pull request BogdanNagirniak/blender#30 2023-04-27 23:05:35 +02:00
Fix wrong path for PXR_MTLX_STDLIB_SEARCH_PATHS

I understand that but doing some_path / some_other_path takes care of worrying about the paths

Brian Savery (AMD) approved BogdanNagirniak/blender#29 2023-04-27 00:46:34 +02:00
Add IBL support
Brian Savery (AMD) commented on pull request BogdanNagirniak/blender#30 2023-04-27 00:45:28 +02:00
Fix wrong path for PXR_MTLX_STDLIB_SEARCH_PATHS

Isn't there a more compact way to do this in python? Seems you're going back and forth from string to path and using path separators? If it's a path you shouldn't have to use os.pathseparator.

Brian Savery (AMD) commented on pull request blender/blender#105538 2023-04-22 01:48:41 +02:00
Cycles: HIP-RT for AMD hardware ray-tracing

Thanks for all the testing. However, every user out there, you do NOT have the correct driver yet, so please hold off reporting anything else until we give an update of which driver to use (Will…