Fix #109968: Allow Warping on Actual Mouse Bounds #113066
No reviewers
Campbell Barton
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#113066
Loading…
Reference in New Issue
No description provided.
Delete Branch "Harley/blender:Fix109968"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
For Color Circle (and Square) and for Walk Navigation, use the actual
region bounds for mouse warping.
I'm still nervous about using Windows API
ClipCursorfor the wrapping code (#109968) because of its potential for catastrophic result if we fail to undo it for some edge or error case.@ideasman42 - I've mentioned this issue with the wrapping bounds before, but I have just a bit more evidence.
With current code (in these cases) the wrapping bounds is set from the window's extent, reduced to a quarter, and centered. With this I can recreate the cursor jumping after a fairly short period of time, and it reproduces well. If I increase the region size, by not quartering, the problem goes away. And as I decrease the size it gets steadily worse. More importantly, if I set the wrapping bounds to the actual region bounds (of the color circle) the problem also goes away, and this is smaller than the original quartered region.
So this PR does minimum changes to fix this complaint and still not cause the "mouse escape" issue for Walk Navigation. This just allows both setting and getting the warp bounds, regardless of warp type. And then passes, and uses, the actual bounds for color circle/square and walk.
Hmm... this alters, but does not fix #111666. That report shows dragging on numerical inputs in the Redo panel (only) showing the mouse outside of that area while dragging. This PR shows the mouse cursor too in this case, but constrained within the numerical input. Weird.
Now fixes #111666 by hiding and restoring the mouse cursor if GHOST_kGrabHide
Still will introduce back #102346
and not only with walk fly navigation, in this video the mouse ends leaving blender on move object
Also I notice some lag editing some inputs
setCursorPositiondon't guarantee that the mouse will be placed at the location, that's is the cause that are some strange behaviorI keep trying that and not seeing it ever end the operation
Same here, not seeing this problem yet.
If that is the primary cause of issues, I just added ClipCursor setting and clearing around setCursorPosition.
This are more like jumps:
(i made some changes to see the mouse position)
Maybe a different dpi mouse setting
And still the mouse can leave
I believe that setting
ClipCursorhave same issue withsetCursorPosition, the next mouse eventscouldbe outdated too.@guishe
Hey, I've now ripped out almost all the complexity and workarounds in that
processCursorEvent. Now doing the wrapping only when the cursor is outside the bounds. Still not managing to have the color picker screw up or Walk Navigation to end.WIP: Fix #109968: Use Actual Region When Wrapping Cursorto WIP: Fix #109968: Only Wrap Cursor When Out of BoundsProbably the most important thing to keep in mind is that the original complaint does not involve cursor warping. At least it shouldn't because the mouse does not leave the color circle for the bad behavior to occur. So you can do the following:
The warping is turned off but the original complaint is solved. That is why the current version of this PR doesn't do any cursor warping unless the mouse is outside of the bounds.
This is a solution to avoid redrawing the depth buffer for each Zoom with `Auto Depth`. The solution is to move the `ED_view3d_depth_override` function out of `ED_view3d_autodist`. `ED_view3d_depth_override` is now only called for navigation operations if it does not meet the following condition: ``` bool has_depth_buffer = !(v3d->flag2 & V3D_HIDE_OVERLAYS) || ELEM(v3d->shading.type, OB_SOLID, OB_MATERIAL) || XRAY_FLAG_ENABLED(v3d) || v3d->shading.type == OB_RENDER && (strcmp(DEG_get_evaluated_scene(depsgraph)->r.engine, RE_engine_id_BLENDER_EEVEE) == 0 || strcmp(DEG_get_evaluated_scene(depsgraph)->r.engine, RE_engine_id_BLENDER_WORKBENCH) == 0); ```The goal here is to make it easier to use the socket declaration builder for cases where the actual socket type is not known at compile time. For that purpose, all the methods that are not dependent on the specific socket type are moved to the base socket declaration builder. A nice side effect of this is reduced templated boilerplate and that more code can be moved out of the header. With this patch, one is now forced to put type specific method calls before generic method calls in a chain. For example `.default_value(...).supports_field()` instead of `supports_field().default_value(...)`. In theory, we could keep support for both orders but that would involve a lot of additional boilerplate code. Enforcing this order is simple enough. Note that this limitation only applies when chaining multiple method calls. This is still possible: ``` auto &decl = b.add_input<decl::Vector>("Value"); decl.supports_field(); decl.default_value(...); ``` Pull Request: #113410WIP: Fix #109968: Only Wrap Cursor When Out of Boundsto WIP: Fix #109968: Only Wrap Cursor When Out of Bounds20e89dc6b5to1ce1db21b9WIP: Fix #109968: Only Wrap Cursor When Out of Boundsto WIP: Fix #109968: Only Wrap Cursor When Out of BoundsWIP: Fix #109968: Only Wrap Cursor When Out of Boundsto Fix #109968: Allow Warping on Actual Mouse Bounds@blender-bot build